Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect github app ID for gitAuthor #269

Open
natan-abolafya opened this issue Apr 12, 2023 · 6 comments
Open

Detect github app ID for gitAuthor #269

natan-abolafya opened this issue Apr 12, 2023 · 6 comments
Assignees

Comments

@natan-abolafya
Copy link

natan-abolafya commented Apr 12, 2023

These:
image

Every PR created by renovate gets this comment on the next processing time.
I am not sure when this exactly started but I am guessing after we started using "platformCommit":true.
It seems to be due to git commit author getting a prefix of sort. So this might be a github setting issue but I am not sure where to look at.

Relevant debug log:

DEBUG: branch.isModified() = true (repository=appgate-sdp-int/ztp-adapter-scheduler, branch=renovate/peter-evans-create-or-update-comment-3.x)
       "branchName": "renovate/peter-evans-create-or-update-comment-3.x",
       "lastAuthor": "98109129+renovate-appgate[bot]@users.noreply.github.com",
       "gitAuthorEmail": "renovate-appgate[bot]@users.noreply.github.com"

So not sure where that 98109129+ comes from but I can see that on git also. I don't have the logs when the original PR was created unfortunately. But if you tell me what word to look for creating a new PR in the debug logs, I can hopefully dig up one.

@rarkins
Copy link
Member

rarkins commented Apr 12, 2023

The number is your app's unique ID. If you configure gitIgnoredAuthors=98109129+renovate-appgate[bot]@users.noreply.github.com then it should go away. In future we can ideally automatically detect that.

@natan-abolafya
Copy link
Author

ah, thanks. Should I close the issue or shall we leave this as a feature request for automatic detection?

@rarkins
Copy link
Member

rarkins commented Apr 12, 2023

We can leave it open until it's automatically supported

@rarkins rarkins changed the title Every PR gets "Edited/Blocked Notification" comment Detect github app ID for gitAuthor Apr 23, 2023
@nabeelsaabna
Copy link
Contributor

Hi @natan-abolafya
this already handled started from release 6.0.0

@rarkins rarkins closed this as completed Oct 26, 2023
@dctrwatson
Copy link

this already handled started from release 6.0.0

As of 6.2.0 the github app auto-detected gitAuthor is still missing the app id and requires adding it manually to gitIgnoredAuthors.

@rarkins rarkins reopened this Oct 27, 2023
@jamietanna
Copy link
Contributor

I believe this is now done on the 7.x releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants