New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istio-proxy could be added twice in `ContainerResourceRequests` #355

Open

sanposhiho opened this issue Feb 24, 2024 · 0 comments

Labels

kind/bug

Collaborator

sanposhiho commented Feb 24, 2024

istio-proxy could be added twice in ContainerResourceRequests if the deployment has the sidecar injection annotation and it's using the custom injection:
https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#customizing-injection

...
  template:
    metadata:
      annotations:
        sidecar.istio.io/inject: "true"
        sidecar.istio.io/proxyCPU: 502m
    spec:
      containers:
      - name: istio-proxy # https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#customizing-injection
        resources:
          requests:
            cpu: 501m
            memory: 129Mb

The text was updated successfully, but these errors were encountered:

sanposhiho added the kind/bug label

sanposhiho mentioned this issue

handle custom istio injection #356

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment