Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV stringify #317

Open
tshemsedinov opened this issue Dec 18, 2019 · 6 comments
Open

CSV stringify #317

tshemsedinov opened this issue Dec 18, 2019 · 6 comments

Comments

@tshemsedinov
Copy link
Member

We need to implement analog of https://www.npmjs.com/package/csv-stringify but we don't need everything, only callback-api https://csv.js.org/stringify/api/#callback-api

stringify(data, (err, str) => { });
@tshemsedinov
Copy link
Member Author

tshemsedinov commented Jan 3, 2020

You can implement this task together @yehorbk @IegorT it is not so simple, csv specification is a complex serialization format, but we can separate this task into subtasks:

  • API definition and API stub
  • Serialization implementation
  • Code review
  • Serialization optimization
  • Unit tests
  • Examples and docs

Who will be first, please write here, fork and try to start with first subtask. After that second one will wait to review your work with me and merge pull request. Only after that second contributor may start implementation. In parallel first contributor may start implementing unittests. Then you will review code of each other and merge your code into internal branch of this repo so we will test it together.

@yehorbk
Copy link
Member

yehorbk commented Jan 3, 2020

I am ready to work. What I need to fork? Original csv-stringify repo or metarhia/common?

@yehorbk
Copy link
Member

yehorbk commented Jan 3, 2020

I am ready to work. What I need to fork? Original csv-stringify repo or metarhia/common?

I've forked metarhia/common and realized that I need to read the documentation of metatests.

@yehorbk
Copy link
Member

yehorbk commented Jan 3, 2020

I created a branch csv-stringify and added module with stub and tests with basic metatests structure there. Also module connected to library in common.js.
Am I need to write something to README.md?

tshemsedinov added a commit that referenced this issue Jan 9, 2020
PR-URL: #317
Co-Authored-By: Timur Shemsedinov <[email protected]>
tshemsedinov added a commit that referenced this issue Jan 9, 2020
Refs: #317
PR-URL: #323
Co-Authored-By: Timur Shemsedinov <[email protected]>
@tshemsedinov
Copy link
Member Author

@IegorT are you in?
We have a stub in csv branch: https://github.com/metarhia/common/tree/csv
So you can clone it and implement while @yehorbk will start unittests.

@IegorT
Copy link

IegorT commented Jan 18, 2020

Hi, I've done a part of work, and made PR, but could assign to this issue. #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants