Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sortComparePriority contract #318

Open
tshemsedinov opened this issue Dec 23, 2019 · 1 comment · May be fixed by #319
Open

Change sortComparePriority contract #318

tshemsedinov opened this issue Dec 23, 2019 · 1 comment · May be fixed by #319
Labels
enhancement metacontribute

Comments

@tshemsedinov
Copy link
Member

Now: sortComparePriority(<Array>, <string>, <string>)
Needed: sortComparePriority(<Array>)(<string>, <string>)
We use this function only in impress (loading config), now we are going to extract this functionality into separate package @metarhia/config so we may change it without large refactoring.
@Bob-chemist
Copy link

@tshemsedinov, my PR:
Change sortComparePriority contract #319

@Bob-chemist Bob-chemist linked a pull request Jan 9, 2020 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement metacontribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change sortComparePriority contract Bob-chemist/common
2 participants
@tshemsedinov @Bob-chemist