Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git go-patch extract is sensitive to am.threeWay configuration, making patch resolution incompatible with CI in some cases #1233

Open
dagood opened this issue May 31, 2024 · 0 comments

Comments

@dagood
Copy link
Member

dagood commented May 31, 2024

To make it easier to work on patches, I tried setting git config --global am.threeWay true. This means when I run git go-patch apply, it will automatically do 3-way merges, rather than me needing to run git am -3 myself to see if that works.

The problem is that git go-patch extract uses am to detect whether a patch has changes and needs to be re-extracted. So, 3-way merge resolutions won't get checked into the dev's PR. CI doesn't use git am -3, so it fails to apply the patches. Noticed with #1232.

Unsetting am.threeWay for the am used during git go-patch extract should be enough to fix this.

Workaround: git config --global am.threeWay false.


Intentionally setting am.threeWay=true during git go-patch apply might be nice, however this could be confusing, because it might not be obvious that some conflicts were resolved. I think this can wait for #542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant