Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard rule requires fields that are not marked as required #211

Open
eleftherias opened this issue Nov 12, 2024 · 0 comments
Open

Scorecard rule requires fields that are not marked as required #211

eleftherias opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@eleftherias
Copy link
Contributor

For the ruletype scorecard_enabled, if you create a profile and turn on remediation, you must set both retention_days and sarif_file, otherwise you will get an error cannot get PR remediation params: cannot create PR entries: cannot execute content template (index 0): template: Content[0]:26:36: executing "Content[0]" at <.Profile.sarif_file>: map has no entry for key "sarif_file".

We should either mark those fields as requires, which breaks backwards compatibility, or find a way to use the defaults in Minder and any clients.

@eleftherias eleftherias added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant