Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actions_check_pinned_tags to work if exclude is omitted #70

Open
rdimitrov opened this issue Mar 28, 2024 · 0 comments
Open

Fix actions_check_pinned_tags to work if exclude is omitted #70

rdimitrov opened this issue Mar 28, 2024 · 0 comments
Labels
good first issue Good for newcomers P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle

Comments

@rdimitrov
Copy link
Member

There's an issue that if we configure the rule like -

  - type: actions_check_pinned_tags
    def: {}

it fails to find any tags that are unpinned and always passes.

We should fix that by either making the exclude required or update the rego evaluation to work properly.
@evankanderson evankanderson added good first issue Good for newcomers P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage labels Jul 16, 2024
@mesembria mesembria added P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle and removed P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mesembria @evankanderson @rdimitrov