-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Researcher file breaks read_raw_eyelink #12690
Comments
Naively I would expect our reader to proceed line by line looking for |
I don't think that would quite work because our reader can't currently parse the lines that are written between an Usually the lines that are written in these non-recording blocks contain system information and/or information about a Calibration sequence (EyeLink will always stop recording gaze/pupil samples during a calibration sequence.. So if a user kicks out of an experiment to re-calibrate, an Calibration blocks in ASCII files look like this:
In the case of our user, an
Which should solve the problem for the researcher, at least. |
Sure, if it fixes that file then that could work too |
Description of the problem
A researcher has reported that their file breaks
read_raw_eyelink
. I'm reporting the details below, so apologies in advance for the lengthy explanation:Problem
In the specification for their ASCII format, EyeLink states that recording periods (where gaze/pupil data are actually being recorded) should always be demarcated by “START” and “END” lines, as shown below:
For us, this is important because lines in the ASCII file that occur outside these
START…END
recording sections are unstructured and, IMO, are difficult to parse.In other words,
read_raw_eyelink
looks for theSTART
events, and parses lines until it hits anEND
event. Per Eyelink's specification, we always assume that any givenSTART
event will eventually be followed by anEND
event (before anotherSTART
event occurs).This assumption has held up until now. In the problematic file that the researcher shared, it looks like one of the recording blocks in the file is missing an “END” event, resulting in a format like:
So what happens is that for the block that is missing an
END
event,read_raw_eyelink
tries to parse lines would typically occur outside recording blocks (specifically, these lines contain information about an eyetracking calibration), and thus that it is not prepared for. This breaks the reader.I'm not sure how easy it will be to make our reader robust to this case. I might try some other EyeLink ASCII readers out there to see if they are able to read the file. In the mean time I'm opening this ticket so that we have a record of it.
Steps to reproduce
Link to data
https://drive.google.com/drive/folders/15SpQuoXZlmH6ZBLcOEoc4nzEA7ewoHuK
Expected results
a raw object
Actual results
Additional information
https://mne.discourse.group/t/mne-io-read-raw-eyelink-failure-adjust-times-sub-function-does-not-work-cant-merge/9012
The text was updated successfully, but these errors were encountered: