Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement the Email component based on Aliyun DM #971

Merged
merged 8 commits into from
Jul 26, 2023

Conversation

alilestera
Copy link
Contributor

What this PR does:
Implement the email component based on Aliyun DM
Which issue(s) this PR fixes:

Fixes #836

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

support call aliyun email service

@github-actions
Copy link

Hi @alilestera. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 65.07% and project coverage change: +0.03% 🎉

Comparison is base (8e16fb5) 60.17% compared to head (0a411a7) 60.20%.

❗ Current head 0a411a7 differs from pull request most recent head 642bb15. Consider uploading reports for the commit 642bb15 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
+ Coverage   60.17%   60.20%   +0.03%     
==========================================
  Files         142      143       +1     
  Lines        9942    10005      +63     
==========================================
+ Hits         5983     6024      +41     
- Misses       3186     3201      +15     
- Partials      773      780       +7     
Files Changed Coverage Δ
components/email/aliyun/email.go 65.07% <65.07%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

demo/email/client.go Outdated Show resolved Hide resolved
components/email/aliyun/email.go Outdated Show resolved Hide resolved
components/email/aliyun/email.go Show resolved Hide resolved
@alilestera alilestera requested a review from wenxuwan July 18, 2023 12:57
components/email/meta.go Outdated Show resolved Hide resolved
@wenxuwan wenxuwan enabled auto-merge (squash) July 26, 2023 08:31
@wenxuwan
Copy link
Member

wenxuwan commented Jul 26, 2023

/lgtm
/approve

@alilestera thanks for your contribution

@github-actions
Copy link

[LGTMNOTIFIER] This PR is LGTM

This pull-request has been lgtm by: @wenxuwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs reviewers from an reviewer in each of these files:

Reviewers can indicate their approval by writing /lgtm in a comment
Reviewers can cancel approval by writing /lgtm cancel in a comment

@github-actions github-actions bot added the lgtm label Jul 26, 2023
@github-actions
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: @wenxuwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenxuwan wenxuwan merged commit c484b6c into mosn:main Jul 26, 2023
@github-actions
Copy link

[LGTMNOTIFIER] This PR is LGTM

This pull-request has been lgtm by: @wenxuwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs reviewers from an reviewer in each of these files:

Reviewers can indicate their approval by writing /lgtm in a comment
Reviewers can cancel approval by writing /lgtm cancel in a comment

@github-actions
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: @wenxuwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alilestera alilestera deleted the dev-email-aliyun branch July 28, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop a new component for email API; 为 email API 开发新的组件
2 participants