Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target-colorspace-hint broken on new Nvidia Drivers #15163

Open
6 tasks done
Asinin3 opened this issue Oct 23, 2024 · 8 comments
Open
6 tasks done

target-colorspace-hint broken on new Nvidia Drivers #15163

Asinin3 opened this issue Oct 23, 2024 · 8 comments
Labels

Comments

@Asinin3
Copy link

Asinin3 commented Oct 23, 2024

mpv Information

mpv v0.39.0-170-g37159a8e Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Oct 20 2024 00:05:18
libplacebo version: v7.349.0 (v7.349.0-18-g9e16c86-dirty)
FFmpeg version: N-117613-g72e538112
FFmpeg library versions:
   libavcodec      61.22.100
   libavdevice     61.4.100
   libavfilter     10.6.100
   libavformat     61.9.100
   libavutil       59.44.100
   libswresample   5.4.100
   libswscale      8.6.100

Other Information

- Windows version: W11 23H2
- GPU model, driver and version: RTX 4090, 566.03
- Source of mpv: https://github.com/shinchiro/mpv-winbuild-cmake/releases
- Introduced in version: N/A

Reproduction Steps

Use Nvidia Driver 565.90 or later
Set "target-colorspace-hint=yes" in mpv.conf
Play a HDR video while windows is in SDR

Expected Behavior

MPV Should set Windows to HDR with the above config when playing a HDR video

Actual Behavior

HDR isn't being enabled automatically after the Nvidia driver update

Log File

output.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@Asinin3 Asinin3 added the os:win label Oct 23, 2024
@llyyr
Copy link
Contributor

llyyr commented Oct 23, 2024

Please report on Nvidia's forums or wherever they want you to report bugs. There's nothing mpv can do about this

@Andarwinux
Copy link
Contributor

Any way to bypass Windows HDR is a completely unsupported hack, so the "auto HDR toggle" is actually an unintended behavior. The fix for this bug has been merged into the R560 branch.

To enable HDR support, Windows HDR must be enabled. this is not NVIDIA or mpv's fault.

August 7th, 2024 - Windows 552.93, Linux 550.40.67

New:
VK_EXT_device_fault
VK_NV_extended_sparse_address_space [Linux]
Fixes:
Improve Vulkan HDR behavior on Windows to not override user's Windows HDR Display settings

@Asinin3
Copy link
Author

Asinin3 commented Oct 23, 2024

Please report on Nvidia's forums or wherever they want you to report bugs. There's nothing mpv can do about this

I understand, but its still good to have this tracked here for reference.

Any way to bypass Windows HDR is a completely unsupported hack, so the "auto HDR toggle" is actually an unintended behavior. The fix for this bug has been merged into the R560 branch.

To enable HDR support, Windows HDR must be enabled. this is not NVIDIA or mpv's fault.

August 7th, 2024 - Windows 552.93, Linux 550.40.67
New:
VK_EXT_device_fault
VK_NV_extended_sparse_address_space [Linux]
Fixes:
Improve Vulkan HDR behavior on Windows to not override user's Windows HDR Display settings

This is intriguing, many PC games on Windows could trigger enabling HDR in the OS, e.g Doom Eternal, MK11 or various Capcom games without the user manually changing their windows settings. I'll have to see if that broke on the new driver too then.

@Andarwinux
Copy link
Contributor

Games can enable Windows HDR on behalf of the user, or use NvAPI, but mpv only uses Vulkan API, and if the Vulkan API doesn't elevate such a hack to a supported operation, then mpv won't have to attempt it.

Drivers, on the other hand, need to conform to the platform specification, so they don't and shouldn't provide hacks.

@laodaoxp
Copy link

laodaoxp commented Nov 9, 2024

请在 Nvidia 论坛或他们希望您报告错误的任何地方进行报告。 mpv对此无能为力

我明白,但在这里跟踪一下以供参考还是很好的。

任何绕过 Windows HDR 的方法都是完全不受支持的黑客行为,因此“自动 HDR 切换”实际上是一种意外行为。此错误的修复已合并到 R560 分支中。
要启用 HDR 支持,必须启用 Windows HDR。这不是 NVIDIA 或 mpv 的错。

2024 年 8 月 7 日 - Windows 552.93、Linux 550.40.67
新增:
VK_EXT_device_fault
VK_NV_extended_sparse_address_space [Linux]
修复:
改进 Windows 上的 Vulkan HDR 行为,以不覆盖用户的 Windows HDR 显示设置

有趣的是,Windows 上的许多 PC 游戏都可以在操作系统中触发启用 HDR,例如《毁灭战士:永恒》、MK11 或各种 Capcom 游戏,而无需用户手动更改其 Windows 设置。我得看看新驱动程序是否也出现这种情况。

Is there a way to solve this problem? After reading the answer here Should be
2.August 7th, 2024 - Windows 552.93, Linux 550.40.67
Improve Vulkan HDR behavior on Windows to not override user's Windows HDR Display settings
My current solution is to use a driver lower than Nvidia Driver 565.90. For example: Driver version: 561.09
4. Currently, there is no other way to wait for me to come home from work. I am testing Potplayer
potplayer+LAV+MadVR
potplayer+LAV+MpcVideoRendere
This combination used to be able to automatically start HDR like MPVs, let's see if they are also affected?

@laodaoxp
Copy link

laodaoxp commented Nov 9, 2024

Please report on Nvidia's forums or wherever they want you to report bugs

我准备去 Please report on Nvidia's forums or wherever they want you to report bugs 试试看

@laodaoxp
Copy link

laodaoxp commented Nov 9, 2024

请在 Nvidia 论坛或他们希望您报告错误的任何地方进行报告。 mpv对此无能为力
I have already provided feedback and I am not sure if it has been effective
000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants