Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 16:10 aspect-ratio #15324

Open
ahimta opened this issue Nov 16, 2024 · 1 comment
Open

Missing 16:10 aspect-ratio #15324

ahimta opened this issue Nov 16, 2024 · 1 comment

Comments

@ahimta
Copy link
Contributor

ahimta commented Nov 16, 2024

Expected behavior of the wanted feature

When clicking Ctrl+A repeatedly never get 16:10 aspect-ratio.

I looked into two likely relevant-parts which are the following:

  1. RATIO_CASE(16.0 / 10.0, "16:10");
  2. else if (doubles_equal(aspect_ratio, 16.0 / 10.0))

But both don't help-much. Seems this is more concerned with mpv-properties which probably, and for very good-reasons, has significant-levels of indirection.

Honestly such changes better done by a maintainer as it's easier than even discussing/explaining to others. Unless what's needed/decided is to resolve some indirection or simplify the design/system to make such-details more tractable.

Alternative behavior of the wanted feature

When clicking Ctrl+A repeatedly and around 16:9 aspect-ratio, should get to 16:10 aspect-ratio.

Log File

No response

Sample Files

No response

@guidocella
Copy link
Contributor

That's defined in

#A cycle-values video-aspect-override "16:9" "4:3" "2.35:1" "-1" # cycle the video aspect ratio ("-1" is the container aspect)
. You can rebind shift+a to cycle through any aspect you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants