Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Review M3 token naming format #41136

Open
DiegoAndai opened this issue Feb 16, 2024 · 0 comments
Open

[material-ui] Review M3 token naming format #41136

DiegoAndai opened this issue Feb 16, 2024 · 0 comments
Assignees
Labels
customization: theme Centered around the theming features design: material you enhancement This is not a bug, nor a new feature on hold There is a blocker, we need to wait package: material-ui Specific to @mui/material

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 16, 2024

From #29345 (comment):

The CSS tokens used don't appear to follow M3 guidelines fully. Like the tokens generated by https://material-foundation.github.io/material-theme-builder/ and https://github.com/material-foundation/material-color-utilities are completely kebab-cased (like --md-sys-color-on-primary) but @mui/material-next appear to have the last part camel-cased (like --md-sys-color-onPrimary).
Is this something overlooked or am I missing something? Just saying coz, it would be great if all the libraries using M3 followed it completely (like https://github.com/material-components/material-web) so that they could be drop-in replaced easily and not worry about matching themes.

We should review our current CSS variable naming format so it makes copying themes as easy as possible.

Search keywords: M3 tokens

@DiegoAndai DiegoAndai added on hold There is a blocker, we need to wait customization: theme Centered around the theming features enhancement This is not a bug, nor a new feature design: material you labels Feb 16, 2024
@DiegoAndai DiegoAndai added this to the Material UI: v7 (draft) milestone Feb 16, 2024
@DiegoAndai DiegoAndai self-assigned this Feb 16, 2024
@DiegoAndai DiegoAndai changed the title [material-ui] Review token naming format [material-ui] Review M3 token naming format Feb 16, 2024
@DiegoAndai DiegoAndai added the package: material-ui Specific to @mui/material label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features design: material you enhancement This is not a bug, nor a new feature on hold There is a blocker, we need to wait package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

2 participants