Formatting suggestion: if-blocks with multiple conditions

[mikez]

Hi @mvdan, I have a formatting suggestion involving if-blocks.

Instead of doing this:

a='aaa'
b='bbb'
c='ccc'
if [[ 
    $a == 'aaa' &&
    $b == 'bbb' &&
    $c == 'ccc' ]] \
    ; then
    echo yes
    # ...
fi

reformat like this:

a='aaa'
b='bbb'
c='ccc'
if [[
    $a == 'aaa'
    && $b == 'bbb'
    && $c == 'ccc'
]]; then
    echo yes
    # ...
fi

The formatting is inspired by what Python does with the black formatter. I think it makes the code more readable. (For operator placement, see also here.)

[ColemanTom]

I would tend to agree, but recognise others may not. It makes diffs better if you add a new condition, its just a new line being added, rather than a new line being added and the ccc line being changed to shift the closing brackets.

The placement of || or && I think should be governed by the --binary-next-line option perhaps, although that negates my comment about which lines change in a diff.

[mikez]

@pschmitt it seems you're confused. Want to elaborate? :)