-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reading from file redirection in while loops waits indefinitely #1099
Comments
Confirmed that it broke in 3.9.0. It works in 3.8.0. |
I tried to write a test that would fail, but I can't seem to get a diff --git a/interp/interp_test.go b/interp/interp_test.go
index 8b535ce3..4a4e1f2a 100644
--- a/interp/interp_test.go
+++ b/interp/interp_test.go
@@ -2905,6 +2905,10 @@ done <<< 2`,
"while read a; do echo $a; GOSH_CMD=exec_ok $GOSH_PROG; done <<EOF\na\nb\nc\nEOF",
"a\nexec ok\nb\nexec ok\nc\nexec ok\n",
},
+ {
+ "while read a; do echo $a; done < <(echo x)",
+ "x\n",
+ },
// TODO: our final exit status here isn't right.
// {
// "while read a; do echo $a; GOSH_CMD=exec_fail $GOSH_PROG; done <<< 'a\nb\nc'", $ cd interp/
$ go test
PASS
ok mvdan.cc/sh/v3/interp 2.808s |
Here's a better test that won't run into Windows compatibility issues. I've based off of 3.8.0 and confirmed it passes in CI and it fails in CI for master. diff --git a/interp/interp_test.go b/interp/interp_test.go
index 8b535ce3..877d8c7a 100644
--- a/interp/interp_test.go
+++ b/interp/interp_test.go
@@ -2905,6 +2905,10 @@ done <<< 2`,
"while read a; do echo $a; GOSH_CMD=exec_ok $GOSH_PROG; done <<EOF\na\nb\nc\nEOF",
"a\nexec ok\nb\nexec ok\nc\nexec ok\n",
},
+ {
+ "echo x > f; while read a; do echo $a; done < f",
+ "x\n",
+ },
// TODO: our final exit status here isn't right.
// {
// "while read a; do echo $a; GOSH_CMD=exec_fail $GOSH_PROG; done <<< 'a\nb\nc'", No idea how to solve the actual bug. |
In v3.9.0 of the gosh interpreter there is an issue with reading from file or file substitutions in
while
loops. The script just hangs when attempting to read from a file or file substitution.This did work recently. I haven't narrowed down the exact version it broke in yet. I discovered this through it breaking in my Taskfile usage.
Examples
Works: Reading from pipe
Hangs: Reading from file
results in this hanging forever
Hangs: Reading from file substitution
results in this hanging forever
The text was updated successfully, but these errors were encountered: