Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more accurate global allocation pool defintion #70

Open
ALSchwalm opened this issue Jul 24, 2020 · 2 comments
Open

Create more accurate global allocation pool defintion #70

ALSchwalm opened this issue Jul 24, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ALSchwalm
Copy link
Collaborator

Currently the global allocator is allocated from a region that is found by the following algorithm:

  1. Get the range of available addresses from the multiboot info
  2. Get the range of excluded addresses (because they are occupied by other modules, elf sections, etc)
  3. Allocate from the portion of the available addresses that is past the end of the maximum excluded address

This is obviously not correct. If, for example, there is an excluded address at the end of the available regions, this will fail. It is also not guaranteed to produce the largest available range.

See https://github.com/mythril-hypervisor/mythril/blob/master/mythril_multiboot2/src/main.rs#L128

@ALSchwalm
Copy link
Collaborator Author

This probably relates to #85

@ALSchwalm
Copy link
Collaborator Author

When this is done, it would be good to develop a series of tests as well. It seems like that should be pretty doable.

@ALSchwalm ALSchwalm added the good first issue Good for newcomers label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant