Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US holidays wrong dates for some years #674

Open
a-nasstrom opened this issue Aug 29, 2024 · 4 comments
Open

US holidays wrong dates for some years #674

a-nasstrom opened this issue Aug 29, 2024 · 4 comments
Assignees

Comments

@a-nasstrom
Copy link

Endpoint

https://date.nager.at/api/v2/publicholidays/2023/US

More information

2022/US, 2023/US, 2028/US +
for some years, the date is shifted by 1-2 days
image
image

image
@tinohager
Copy link
Member

The WebApi currently shows the day when the holiday is actually celebrated, with the shift.

@tinohager tinohager self-assigned this Aug 29, 2024
@a-nasstrom
Copy link
Author

this is confusing. maybe possible to add a separate field that will be responsible for the day of celebration?

@tinohager
Copy link
Member

Yes, since version 2 of Nager.Date. Do we have this information available for the. It is planned to make this information available via the RestAPI as well.

@a-nasstrom
Copy link
Author

I would be grateful if you do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants