Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete app when spec is wrong #563

Open
jhrv opened this issue Sep 10, 2024 · 1 comment
Open

Unable to delete app when spec is wrong #563

jhrv opened this issue Sep 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jhrv
Copy link
Contributor

jhrv commented Sep 10, 2024

User tried to delete app in Console, but nothing happened.
https://nav-it.slack.com/archives/C5KUST8N6/p1725951754452269

Running kubectl describe app ds-api we saw the following event

Application.nais.io "ds-api" is invalid: spec.gcp.sqlInstances[0].tier: Invalid value: "": spec.gcp.sqlInstances[0].tier in body should match 'db-.+'

So the tier was missing, and spec was invalid.

This resulted in kubectl delete app ds-api hanging indefinitely.

When removing the failing spec, the application was deleted as expected.

Another similar issue:
https://nav-it.slack.com/archives/C5KUST8N6/p1724998208664699

Expected behavior:
The invalid spec should never have been accepted in the first place, or changes made to naiserator regarding tier (if this was done after this spec was already accepted) should have cleaned this up.

Edit: ☝️ https://nav-it.slack.com/archives/C01DE3M9YBV/p1724141273103439 seems to have introduced this

@kimtore kimtore added the bug Something isn't working label Sep 10, 2024
@jhrv
Copy link
Contributor Author

jhrv commented Sep 10, 2024

Actually, the expected behavior is that the application should be possible to delete regardless of any invalid elements in the spec. However the expected behavior describe above is still true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants