Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use milestone and ignore merge status #14

Open
jni opened this issue Sep 29, 2024 · 0 comments
Open

Use milestone and ignore merge status #14

jni opened this issue Sep 29, 2024 · 0 comments

Comments

@jni
Copy link
Member

jni commented Sep 29, 2024

When it's close to release date we make a lot of add/remove from milestone decisions quickly. With the current state of the release script, we have to use --with-pr many times to signal intent to merge. And, as new PRs are added or removed from the milestone, the invocation of the script needs to change each time.

Instead, the milestone itself should be the signal of intent. That way, we can just invoke the script repeatedly as milestones are edited. The milestone itself becomes the single source of truth, and using the script is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant