Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech review for spectra_generator.md #336

Open
jkrick opened this issue Sep 18, 2024 · 1 comment
Open

tech review for spectra_generator.md #336

jkrick opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
use case: spectroscopy Spectroscopy use case

Comments

@jkrick
Copy link
Contributor

jkrick commented Sep 18, 2024

This notebook needs a tech review. I think it got a quick check by Troy a while back, but can either @bsipocz or @troyraen please do a tech review?

We don't intend to scale the notebook up, so functions do not need to be modified for efficiency.

@jkrick jkrick added the use case: spectroscopy Spectroscopy use case label Sep 18, 2024
@troyraen
Copy link
Contributor

When reviewing, see also: #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
use case: spectroscopy Spectroscopy use case
Projects
None yet
Development

No branches or pull requests

3 participants