diff --git a/packages/vue/src/components/HeroInlineMedia/HeroInlineMedia.vue b/packages/vue/src/components/HeroInlineMedia/HeroInlineMedia.vue index 79e75e64..26a1b852 100644 --- a/packages/vue/src/components/HeroInlineMedia/HeroInlineMedia.vue +++ b/packages/vue/src/components/HeroInlineMedia/HeroInlineMedia.vue @@ -41,7 +41,6 @@ const { heroBlocks, constrain } = reactive(props) { }) const heroInline = computed((): boolean => { - // heroes with interactive elements have special handling if (theHero.value && !heroTitle.value) { - // excludes VideoBlock as this will autoplay - if (theHero.value.blockType === 'VideoBlock') { - return false - } else if ( + // heroes with interactive elements have special handling + if ( data?.heroPosition === 'inline' || theHero.value.blockType === 'CarouselBlock' || theHero.value.blockType === 'IframeEmbedBlock' || @@ -127,6 +124,7 @@ const heroInline = computed((): boolean => { ) { return true } + return false } return false }) diff --git a/packages/vue/src/templates/edu/PageEduStudentProject/PageEduStudentProject.vue b/packages/vue/src/templates/edu/PageEduStudentProject/PageEduStudentProject.vue index 648f8f0f..a6461214 100644 --- a/packages/vue/src/templates/edu/PageEduStudentProject/PageEduStudentProject.vue +++ b/packages/vue/src/templates/edu/PageEduStudentProject/PageEduStudentProject.vue @@ -92,12 +92,9 @@ const heroTitle = computed((): boolean => { }) const heroInline = computed((): boolean => { - // heroes with interactive elements have special handling if (theHero.value && !heroTitle.value) { - // excludes VideoBlock as this will autoplay - if (theHero.value.blockType === 'VideoBlock') { - return false - } else if ( + // heroes with interactive elements have special handling + if ( data?.heroPosition === 'inline' || theHero.value.blockType === 'CarouselBlock' || theHero.value.blockType === 'IframeEmbedBlock' || @@ -106,6 +103,7 @@ const heroInline = computed((): boolean => { ) { return true } + return false } return false }) diff --git a/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue b/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue index 7424e35a..8962e9c0 100644 --- a/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue +++ b/packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue @@ -52,12 +52,9 @@ const heroTitle = computed((): boolean => { }) const heroInline = computed((): boolean => { - // heroes with interactive elements have special handling if (theHero.value && !heroTitle.value) { - // excludes VideoBlock as this will autoplay - if (theHero.value.blockType === 'VideoBlock') { - return false - } else if ( + // heroes with interactive elements have special handling + if ( data?.heroPosition === 'inline' || theHero.value.blockType === 'CarouselBlock' || theHero.value.blockType === 'IframeEmbedBlock' || @@ -66,6 +63,7 @@ const heroInline = computed((): boolean => { ) { return true } + return false } return false })