Windows Related Changes pt2 ( windows changes + aws cli replacement with boto3 ) #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqr00t
reviewed
Sep 28, 2023
| @@ -24,7 +31,7 @@ def read_lines(path): | |||
|
|
|||
| setup( | |||
| name="ojd_daps_skills", | |||
| long_description=open(os.path.join(BASE_DIR, "README.md")).read(), | |||
| long_description=open(os.path.join(BASE_DIR, "README.md"), encoding="utf-8").read(), | |||
There was a problem hiding this comment.
This, is exactly what I was trying find for an encoding error. Very nice!
|
I'd merge this into my branch to double check any conflicts. Thank you for your contributions! 💯 edit: there's actually no conflicts, I'll revert this to merge to dev after discussing with @lizgzil and @india-kerle |
This was
linked to
issues
Sep 28, 2023
sqr00t
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
@Aiden-RC I wonder if you're able to squash and merge into the 201_update_dependencies branch put this comment on hold!
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts @Aiden-RC 's snippet for download() function using boto3
Adds pip dependency caching for "Unit Tests" workflow
Adds windows-latest support to "Unit Tests" Actions workflow
Removes awscli from requirements_dev.txt
Updates following dependencies:
Thanks for contributing to Nesta's Skills Extractor Library 🙏!
If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.
Checklist ✔️🐍:
notebooks/pre-commitand addressed any issues not automatically fixeddevREADMEsoutput/reports/If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.
Documentation Checklist ✔️📚:
make htmlindocsdocs/build/*.htmlfiles locally to ensure they have formatted correctlydocs/build/*.htmlfiles