Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget packages are not built in release mode #186

Open
fjmorel opened this issue Jun 2, 2021 · 3 comments
Open

Nuget packages are not built in release mode #186

fjmorel opened this issue Jun 2, 2021 · 3 comments

Comments

@fjmorel
Copy link

fjmorel commented Jun 2, 2021

After seeing this blog post, I checked my projects for debug nuget packages and found Common.Logging to be the only one.

https://garcia.in/posts/2021/pitfalls-of-unoptimized-nuget-packages/

~\.nuget\packages\unoptimizedassemblydetector\0.1.0\build\UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Common.Logging.Core.dll' at ~\.nuget\packages\common.logging.core\3.4.1\lib\netstandard1.0\Common.Logging.Core.dll [~\source\repos\Project.csproj]
~\.nuget\packages\unoptimizedassemblydetector\0.1.0\build\UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Common.Logging.dll' at ~\.nuget\packages\common.logging\3.4.1\lib\netstandard1.3\Common.Logging.dll [~\source\repos\Project.csproj]
@hfickes
Copy link

hfickes commented Jul 13, 2023

This is an issue for us as well and is two years old.

Is common-logging an abandoned project?

@fjmorel
Copy link
Author

fjmorel commented Jul 14, 2023

With the rise of Microsoft.Extensions.Logging.... probably.

This is no longer in my dependency tree.

@hfickes
Copy link

hfickes commented Jul 14, 2023

We use a package, Spring.Net, which in turn uses the latest common.logging. We can't use the various latest logging targets such as log4net nor nlog since the common.logging which Spring uses, won't work with the latest of the others.

We may just throw out common.logging and directly use log4net etc instead. We weren't using any logging from Spring.Net, it just forced us to also include common.logging which we then in turn used because, well it was easy to. We'll still have to carry it around, but we won't be using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants