Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use statements #12

Open
come-nc opened this issue Sep 18, 2024 · 0 comments
Open

use statements #12

come-nc opened this issue Sep 18, 2024 · 0 comments
Labels
question Further information is requested

Comments

@come-nc
Copy link
Collaborator

come-nc commented Sep 18, 2024

rector tends to output fully qualified names, unless one uses the withImportNames option (see https://getrector.com/documentation/import-names ).

This is a bit annoying in a lot of cases.

I tried to see if there was an easy way of adding modified nodes to the autoimport mechanism without messing with the rest of the file but I failed so I’m not sure if there is an easy win here.
Maybe we need to bite the bullet and apply withImportNames to our code. But serious tests need to be done first for when there are collisions and stuff like that.

@come-nc come-nc added the question Further information is requested label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant