Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate annotations to attribute in 30 set #17

Open
come-nc opened this issue Sep 18, 2024 · 3 comments
Open

Migrate annotations to attribute in 30 set #17

come-nc opened this issue Sep 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@come-nc
Copy link
Collaborator

come-nc commented Sep 18, 2024

From upgrade to 30 documentation:

  • Using the @PasswordConfirmationRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\PasswordConfirmationRequired] attribute should be used instead.
  • Using the @CORS annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\CORS] attribute should be used instead.
  • Using the @PublicPage annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\PublicPage] attribute should be used instead.
  • Using the @ExAppRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\ExAppRequired] attribute should be used instead.
  • Using the @AuthorizedAdminSetting annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\AuthorizedAdminSetting] attribute should be used instead.
  • Using the @SubAdminRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\SubAdminRequired] attribute should be used instead.
  • Using the @NoAdminRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\NoAdminRequired] attribute should be used instead.
  • Using the @StrictCookieRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\StrictCookiesRequired] attribute should be used instead.
  • Using the @NoCSRFRequired annotation is deprecated and the #[OCP\AppFramework\Http\Attribute\NoCSRFRequired] attribute should be used instead.
@come-nc come-nc added the enhancement New feature or request label Sep 18, 2024
@provokateurin
Copy link

Technically they have been deprecated way earlier in the moment when we added the attributes. I only added some debugging logging in case the annotations are still used and took the time to also not that down in the changelog.
For none of the attributes you need 30, so we can move them to some earlier sets (though they might not all be in the same).

@come-nc
Copy link
Collaborator Author

come-nc commented Sep 19, 2024

Yeah can be done in the version adding the attribute, that works as well.

@provokateurin
Copy link

Would be better because if it was in the 30 set we could only upgrade to them next year while they are already available on all supported versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants