Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot move shared folders to external storages without parent folder #44249

Open
6 of 8 tasks
strangmann opened this issue Mar 16, 2024 · 4 comments
Open
6 of 8 tasks
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: external storage feature: sharing

Comments

@strangmann
Copy link

strangmann commented Mar 16, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

When I try to move a directly shared directory (someone shared it with me) to an external storage, the web interface says that it is not possible to move the item. However, if I move the shared directory to a random folder outside the external storage, I can move the random folder to the external storage.

Steps to reproduce

  1. Configure external Storage as user A
  2. Generate as user A a direct share with user B
    3.1 Login as user B and try to move the folder to external storage (result of MOVE: error 403) -> error
    3.2 Login as user B, create a random directory and move the random folder to exterrnal storage -> success

Expected behavior

The folder should be moved without random folder, not via step 3.2 (by Steps to reproduce).
Otherwise the shared folder should not be moved to external storage.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

RHEL/CentOS

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.19.0
  - admin_audit: 1.17.0
  - bookmarks: 13.1.3
  - bruteforcesettings: 2.7.0
  - calendar: 4.6.5
  - circles: 27.0.1
  - cloud_federation_api: 1.10.0
  - comments: 1.17.0
  - contacts: 5.5.2
  - contactsinteraction: 1.8.0
  - dashboard: 7.7.0
  - dav: 1.27.0
  - deck: 1.11.4
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_external: 1.19.0
  - files_mindmap: 0.0.30
  - files_pdfviewer: 2.8.0
  - files_reminders: 1.0.0
  - files_rightclick: 1.6.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - firstrunwizard: 2.16.0
  - forms: 3.4.6
  - integration_ews: 1.0.37
  - integration_openproject: 2.6.1
  - keeweb: 0.6.13
  - logreader: 2.12.0
  - lookup_server_connector: 1.15.0
  - nextcloud_announcements: 1.16.0
  - notifications: 2.15.0
  - notify_push: 0.6.9
  - oauth2: 1.15.2
  - onlyoffice: 8.2.4
  - password_policy: 1.17.0
  - photos: 2.3.0
  - privacy: 1.11.0
  - provisioning_api: 1.17.0
  - recommendations: 1.6.0
  - related_resources: 1.2.0
  - serverinfo: 1.17.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - spreed: 17.1.6
  - support: 1.10.0
  - survey_client: 1.15.0
  - systemtags: 1.17.0
  - text: 3.8.0
  - theming: 2.2.0
  - theming_customcss: 1.15.0
  - twofactor_backupcodes: 1.16.0
  - updatenotification: 1.17.0
  - user_ldap: 1.17.0
  - user_status: 1.7.0
  - viewer: 2.1.0
  - weather_status: 1.7.0
  - workflow_script: 1.12.1
  - workflowengine: 2.9.0

Nextcloud Signing status

No response

Nextcloud Logs

... [16/Mar/2024:15:17:25 +0100] "MOVE /remote.php/dirToUser/testshare HTTP/2.0" 403 158 "-" ...

Additional info

No response

@strangmann strangmann added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 16, 2024
@strangmann
Copy link
Author

Same error with NC 28

@strangmann
Copy link
Author

Same error in 29.0.5

@strangmann
Copy link
Author

Same issue in 29.0.7

@icewind1991
Copy link
Member

Moving shared files (as the recipient) into external storage is supposed to be blocked. As it would lead to a situation where NC would show the file in the external storage that doesn't actually exist in the external storage.

The "workaround" here is a bug that should be fixed.

Nextcloud show however show a proper error message explaining why the share can't be moved instead of the current generic error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: external storage feature: sharing
Projects
None yet
Development

No branches or pull requests

4 participants