Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an error log message that notifications app isn't enabled at file… #49232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an error log message that notifications app isn't enabled at file… #49232

wants to merge 1 commit into from
+6 −0

Conversation

falghamdi125
Copy link
Contributor

@falghamdi125 falghamdi125 commented Nov 12, 2024 •
edited by solracsf
Loading

Summary

This PR adds an error log message telling admin that the notifications app is not enabled at the files_reminders app loading.

Checklist

Pytal
Pytal reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php Outdated Show resolved Hide resolved
apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php Outdated Show resolved Hide resolved
@falghamdi125 falghamdi125 force-pushed the files_reminders-logging-notifications-app-not-enabled branch from e403b7a to 5ebe213 Compare November 13, 2024 04:51
@solracsf solracsf added this to the Nextcloud 31 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@solracsf solracsf solracsf approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Files_reminders app doesn't load, and no error is shown if the notification app is not installed.
4 participants
@falghamdi125 @solracsf @Pytal @joshtrichards