Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flye to nf-core/bacass #115

Open
lborcard opened this issue Mar 18, 2024 · 12 comments
Open

Add flye to nf-core/bacass #115

lborcard opened this issue Mar 18, 2024 · 12 comments
Assignees

Comments

@lborcard
Copy link

No description provided.

@lborcard lborcard self-assigned this Mar 18, 2024
@d4straub
Copy link
Collaborator

It would be great to have flye in here, but I do want to highlight that currently a template update would be really necessary.

@Daniel-VM
Copy link
Contributor

I'm on it, @d4straub! 👍🏾 I'm encountering a bit of trouble getting the latest template update to work in nf-core/bacass.

@Daniel-VM
Copy link
Contributor

In addition, I would like to mention that we need to consider implementing Flye because it can already be accessed through the Dragonflye module, which is already implemented but in the development branch. I have to make a release ASAP 🏃🏾 .

@lborcard
Copy link
Author

Ok thanks @Daniel-VM , I am now working on adding Flye, it's my first time contributing to nf-core, I was looking for guidance as waht is necessary to do.

@Daniel-VM
Copy link
Contributor

Awesome @lborcard. We have other interesting approaches in mind re: #57 . For example, improving assembled genomes by adding a genome rotation step. We proposed here cyclator or dnaapler or both.

Should we try them?
(Feel free to open a new issue to cover this genome rotation task 😃 )

@lborcard
Copy link
Author

Awesome @lborcard. We have other interesting approaches in mind re: #57 . For example, improving assembled genomes by adding a genome rotation step. We proposed here cyclator or dnaapler or both.

Should we try them? (Feel free to open a new issue to cover this genome rotation task 😃 )

It seems that dnaapler is more recent and recently maintained but I don't have experience with either of these tools.

@lborcard
Copy link
Author

So dnaapler/cyclator would take the output of Dragonflye? is there a module for either of these tools?

@jenmuell
Copy link

Dragonflye is already present as module

@Daniel-VM
Copy link
Contributor

So dnaapler/cyclator would take the output of Dragonflye? is there a module for either of these tools?

I think so. I have never tryed yet, but it is likely that dnaapler takes the assembled genome *.fasta emmited by any assembler used in nf-core bacass (dragonflye, unicycler, miniasm, ...).

@lborcard
Copy link
Author

I can work on a dnaapler module if that would help?

@Daniel-VM
Copy link
Contributor

Sure 💯 . Please add a git issue for dnaapler implementation ;).

@lborcard
Copy link
Author

i added it to the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants