Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tab component #18

Open
kedar9444 opened this issue Oct 8, 2019 · 9 comments
Open

Implement tab component #18

kedar9444 opened this issue Oct 8, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@kedar9444
Copy link
Contributor

Implement tab component
@santoshyadavdev santoshyadavdev added the enhancement New feature or request label Oct 8, 2019
@santoshyadavdev
Copy link
Member

Hi @kedar9444 ,
Thanks for adding this, we already have plan to add this. Are you planning to work on it?

@kedar9444
Copy link
Contributor Author

yes, assign it to me.

@kedar9444
Copy link
Contributor Author

Can you explain the requirement bit more, or should take the reference of navbar module to implement this thing?

@santoshyadavdev
Copy link
Member

Hi @kedar9444 ,
Yes you can take the reference. Let us know if you have any question.
We don't want devs to remember all CSS, they can use the component as we do for the Angular material.

@kedar9444
Copy link
Contributor Author

👍👍

@kedar9444
Copy link
Contributor Author

kedar9444 commented Oct 12, 2019 •
edited
Loading

Are you expecting tab content as a part of this implementation, because i am not able to see any example on bulma site which shows tab as well as tab content.

kedar9444 added a commit to angular-way/ngx-bulma that referenced this issue Oct 12, 2019
@kedar9444
Implement tab component ngx-builders#18 : this is basic version of ta…
0d096a2 
…b will add support for allignment,icon,size, style in my next commit.
@kedar9444
Copy link
Contributor Author

kedar9444 commented Oct 13, 2019 •
edited
Loading

@santoshyadav198613 : can you review and close this code.

santoshyadavdev added a commit that referenced this issue Oct 25, 2019
@santoshyadavdev
Merge pull request #28 from angular-way/master
e5acf97 
Implement tab component #18
@kedar9444
Copy link
Contributor Author

I am working on it will commit further code in some time. can we set a release timeline for this library like milestones?

@santoshyadavdev
Copy link
Member

Hey @kedar9444 sorry I was busy with some other work, let's get the first version out after tab component. Thanks for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@santoshyadavdev @kedar9444