Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run automated code formatter to standardize library coding style #467

Open
tsalo opened this issue Aug 6, 2020 · 1 comment
Open

Run automated code formatter to standardize library coding style #467

tsalo opened this issue Aug 6, 2020 · 1 comment

Comments

@tsalo
Copy link
Member

tsalo commented Aug 6, 2020

Summary

This stems from #466 (comment) and #446 (review). The coding style is very variable across the repository, so it would be helpful to standardize this with an automated code formatter, like black.

To do this, we need to merge current PRs and not open any new ones before the formatting PR is merged. I think we should ping the creators of the current PRs to see where they're at and whether they'd be willing to deal with the merge conflicts on their end.

@tsalo
Copy link
Member Author

tsalo commented Aug 6, 2020

To start, I think that #333, #441, #454, and #461 are small enough that the authors can just deal with the merge conflicts after the fact, while #446 is fairly large and should probably be dealt with beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant