Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(workaround): if heuristic provided just a string and not list of types -- make it into a tuple #787

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

yarikoptic
Copy link
Member

This should provide compatibility with prior versions

Closes #786

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.09%. Comparing base (383525d) to head (47b30bb).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
heudiconv/convert.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   82.13%   82.09%   -0.04%     
==========================================
  Files          42       42              
  Lines        4226     4229       +3     
==========================================
+ Hits         3471     3472       +1     
- Misses        755      757       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 2, 2024
@yarikoptic yarikoptic merged commit ade3fd5 into nipy:master Oct 2, 2024
7 of 9 checks passed
Copy link

github-actions bot commented Oct 2, 2024

🚀 PR was released in v1.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heuristic.py for heudiconv 0.10.0 incompatible with heudiconv 1.20 (or 1.1.6) ?
1 participant