From 3906c42dc652e4bc28592af2de9a21fd0f9ee983 Mon Sep 17 00:00:00 2001
From: matteo-grella <matteogrella@gmail.com>
Date: Fri, 22 Jan 2021 11:44:20 +0100
Subject: [PATCH] Rename `ReadOnly` with `Training`

---
 pkg/nlp/transformers/bert/bert.go      | 4 ++--
 pkg/nlp/transformers/bert/converter.go | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/pkg/nlp/transformers/bert/bert.go b/pkg/nlp/transformers/bert/bert.go
index 5e1a64bb..7d3808e1 100644
--- a/pkg/nlp/transformers/bert/bert.go
+++ b/pkg/nlp/transformers/bert/bert.go
@@ -45,7 +45,7 @@ type Config struct {
 	TypeVocabSize         int               `json:"type_vocab_size"`
 	VocabSize             int               `json:"vocab_size"`
 	ID2Label              map[string]string `json:"id2label"`
-	ReadOnly              bool              `json:"read_only"`
+	Training              bool              `json:"training"` // Custom for spaGO
 }
 
 func init() {
@@ -93,7 +93,7 @@ func NewDefaultBERT(config Config, embeddingsStoragePath string) *Model {
 			MaxPositions:        config.MaxPositionEmbeddings,
 			TokenTypes:          config.TypeVocabSize,
 			WordsMapFilename:    embeddingsStoragePath,
-			WordsMapReadOnly:    config.ReadOnly,
+			WordsMapReadOnly:    !config.Training,
 			DeletePreEmbeddings: false,
 		}),
 		Encoder: NewBertEncoder(EncoderConfig{
diff --git a/pkg/nlp/transformers/bert/converter.go b/pkg/nlp/transformers/bert/converter.go
index ce96b2bc..d9d282d8 100644
--- a/pkg/nlp/transformers/bert/converter.go
+++ b/pkg/nlp/transformers/bert/converter.go
@@ -46,6 +46,9 @@ func ConvertHuggingFacePreTrained(modelPath string) error {
 	if err != nil {
 		return err
 	}
+	// Enable training mode, so that we have writing permissions
+	// (for example, for embeddings storage files).
+	config.Training = true
 	vocab, err := vocabulary.NewFromFile(vocabFilename)
 	if err != nil {
 		return err