Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add --version information in tdrop #357

Open
c02y opened this issue May 29, 2022 · 2 comments
Open

Please add --version information in tdrop #357

c02y opened this issue May 29, 2022 · 2 comments

Comments

@c02y
Copy link

c02y commented May 29, 2022

I notice that there is version for tdrop: Update changelog and documentation and bump version to 0.5.0

I don't install tdrop using package manager or makefile, I simply copy the tdrop script into my PATH.

I notice that there no version information inside the tdrop file. So I don't know whether my tdrop needs update to the version in this repo.

Usually I download/save the tdrop file into my local disk and diffs the two files to check if my old tdrop needs updates.

So please add --version to store the version information since tdrop has a version.

@noctuid
Copy link
Owner

noctuid commented May 29, 2022

So I don't know whether my tdrop needs update to the version in this repo.

Even if I added a --version flag, you wouldn't be abe to know if things had changed without a separate check because I'm not tagging every commit. Some software can show the commit hash in the --version output (by getting/setting it at build time), but that's not possible here if you're just downloading the tdrop file.

It would be much simpler for you to just clone the repo somewhere, add it to your path, and just run git pull to get any updates. Even better to follow the suggested installation instructions and run sudo make install afterwards so you get an up-to-date manpage and don't need to alter your path.

@c02y
Copy link
Author

c02y commented May 29, 2022

Sure, I can use a workaround.

Even though you don't have to tag every commit, I only need to sync my local tdrop to the release/tag version instead of the very latest commit.

Even without my personal request, I still think it is better to provide a built-in version number for tdrop.

If you think providing a version number in tdrop file is a bad idea or totally unnecessary, you can simply close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants