Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port case insensitivity #496

Open
chadrik opened this issue Aug 30, 2015 · 6 comments
Open

port case insensitivity #496

chadrik opened this issue Aug 30, 2015 · 6 comments

Comments

@chadrik
Copy link

chadrik commented Aug 30, 2015

I'd like to request that noflo-ui treat port names, and all other names gathered from the runtime, in a case-sensitive fashion. I can't think of a good reason not to.

I thought about this for awhile and at first I was going to suggest that we add a caseSensitive boolean metadata to the runtime registration, but then I thought better of it. noflo-ui should not need to know whether a runtime is case-sensitive or not, it should simply record component and port names exactly as they are provided to it from the runtime, and respond with those same names.

As it is now, noflo-ui will only work with case-insensitive runtimes, because it converts all port names to lowercase.

[edited for clarity]

@jonnor
Copy link
Member

jonnor commented Aug 31, 2015

Agreed completely

@alfa256
Copy link
Contributor

alfa256 commented Aug 31, 2015

👍

@chadrik
Copy link
Author

chadrik commented Aug 31, 2015

I'm not a web dev, but I started digging through the code to try to get a sense of how difficult this would be to fix. What I gathered is that noflo.Graph is the source of the case-insensitivity. I believe the UI is using this for its internal representation of the graph, but it is also used within the various noflo runtimes. So if we want to make noflo-ui case-sensitive, while maintaining the case-insensitivity of noflo's runtimes, we'll likely need a construction argument to tell noflo.Graph how to deal with case-sensitivity. Alternately, the entire noflo ecosystem could be made case sensitive. I'll leave that call up to you all.

@jonnor
Copy link
Member

jonnor commented Sep 1, 2015 via email

@pyvelepor
Copy link

I think I'm still seeing issues with case sensitive port names on the latest version of Flowhub.

I'm working on a project that's trying to use Rill, a Python-based runtime, with flowhub. All of Rill's example components have port names in upper case. In flowhub, after adding one of these components to the graph and modifying one of its inputs, another port appears that is lowercase. The lowercase version is sent to the runtime which results in errors since all the ports are in upper case.

Are non-lowercase port names supported? If so, is the runtime responsible for communicating if case sensitivity needs to be preserved?

@bergie
Copy link
Member

bergie commented Jul 4, 2017

I think the way to go here will be to make case sensitivity a setting you can toggle in graph properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants