Nuemark2.0 issues

[tomByrer]

Doing a quick code review of your dev branch, I am confused if the Blocks or Inline is scanned first? If Blocks, then it seems this code:

 *** Bold Italic ***

Would render as an <hr> since you are just scanning first few characters.?

Also be aware that CommonMark is VERY flexible for <hr>. I personally don't think you need to cover every edge case, but it could help to document "Only the common Markdown/CommonMark rules are covered."

[tipiirai]

@tomByrer @nobkd fixed all issues mentioned on this article

[nobkd]

Thank youu!
I'll check later today, if I find more unexpected results :)

[nobkd]

Input	Expected (Commonmark Spec Implementation)	Nuemark 2
*test** **test*** ***test**** - - - ****test*** ***test** **test*	<p><em>test</em>*</p> <p><strong>test</strong>*</p> <p><em><strong>test</strong></em>*</p> <hr> <p>*<em><strong>test</strong></em></p> <p>*<strong>test</strong></p> <p>*<em>test</em></p>	<p><em>test</em>*</p> <p><strong>test</strong>*</p> <p><em><strong>test</strong></em>*</p> <hr> <p><em><strong>*test</strong></em></p> <p>***test**</p> <p>**test*</p>

The first half (before hr) is correct, the second half is wrong (e.g. position of * in first after hr).

PS: I started building a test using the commonmark-spec test suite. See dev...nobkd:nue:test/cmark-spec. Maybe you want to try using it.

[tipiirai]

No more loops with unclosed image tags such as ![foo *bar*]

[tipiirai]

Are image reflinks like ![foo][bar] supported in Markdown?

[tipiirai]

btw: Nuemark will not support raw HTML, because that violates the separation of concerns principle

[nobkd]

Are image reflinks like ![foo][bar] supported in Markdown?

The commonmark reference implementation does support it: https://spec.commonmark.org/dingus/?text=!%5Bimg%5D%5Btag%5D%0A%0A%5Btag%5D%3A%20%2Fimg.png%0A#result

(PS: did you do the strike through implementation with one tilde (~) or with two (~~)? ~strike~ oder ~~strike~~?
Also, may I know why you used the pipe symbol |marked text| for <mark> and not the (in my opinion) more commonly used ==marked text==? To be more similar to glow?)
(PPS: do we have a simple way to write <details> with <summary>?)

Edit : you can btw remove marked from this tourimage: https://github.com/nuejs/nue/blob/dev/packages%2Fnuejs.org%2Ftour%2Fimg%2Fnpm-nue.png (maybe remove node modules and do a clean install on dev, to get all the dependency changes)

[nobkd]

Found more problems:

1. **bold** not bold **bold**
2. **test**:

expected:

<ol>
  <li><p><strong>bold</strong> not bold <strong>bold</strong></p></li>
  <li><p><strong>test</strong>:</p></li>
</ol>

reality:

<ol>
  <li><p><strong>bold** not bold **bold</strong></p></li>
  <li><p>**test**:</p></li>
</ol>

You can see this issue e.g. on the docs index page in on dev branch: http://localhost:8080/docs/

Edit: maybe the ps should not belong to the list items?

[nobkd]

Nuemark also doesn't support <br> line breaks using two or more spaces at the end of a line or a backslash at the end of a line:

foo  
bar

foo\
bar

expected:

<p>foo<br />
bar</p>
<p>foo<br />
bar</p>