Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unbootable systems if LVM snapshots are present at boot time #17

Open
brianmcgee opened this issue Aug 1, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@brianmcgee brianmcgee added the enhancement New feature or request label Aug 1, 2024
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2024

For systems that use disko it's actually better if we do not detect this in facter and instead make this part of disko: nix-community/disko#796

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2024

Reason is that lvm won't be created at the time we run nixos-facter (we want facter before disko)

@brianmcgee
Copy link
Member Author

This would fall under an "ephemeral" system property and live behind the --ephem flag, meaning by default it wouldn't be captured.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2024

We need it later for the non-disko use case.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2024

For the time being we should mention it in documentation for non-disko users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants