Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --version flag to kyt-cli #491

Open
jaredmcdonald opened this issue May 26, 2017 · 6 comments
Open

add --version flag to kyt-cli #491

jaredmcdonald opened this issue May 26, 2017 · 6 comments

Comments

@jaredmcdonald
Copy link
Contributor

Add a flag to kyt-cli that returns the current version from package.json and exits 0. Should probably be -v and --version. Originally came up in #490.

Bug or Feature?

Feature

@blakeyoder
Copy link

Mind if I take this one? @jaredmcdonald

@jaredmcdonald
Copy link
Contributor Author

all yours, @blakeyoder! thanks

@blakeyoder
Copy link

@jaredmcdonald Quick question on this one. I've noticed that if I run a command such as kyt-cli list then the output starts with the version of yarn that is installed - maybe it has something to do with the symlink at setup?

For example,
kyt-cli list - notice the yarn version at the top

img

This shows up with the command I wrote

kyt-cli version - yarn version first then app version second
img2

I wanted to see if this is happening on your build? I might have just setup something wrong...Thanks!

@ccpricenytimes
Copy link
Contributor

ccpricenytimes commented Jul 19, 2017

This is also happening in my build @blakeyoder
I haven't dug into why yet, but we are seeing it too so you're set up correctly!

@skvale
Copy link

skvale commented May 9, 2018

@skvale
Copy link

skvale commented May 9, 2018

To hide the yarn version from kyt-cli commands, something like

const isYarnInstalled = () => shell.exec('[ -x "$(command -v yarn)" ]').code === 0;

could work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants