Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal React starter-kyt - Tools view #579

Open
nicanordlc opened this issue Dec 14, 2018 · 0 comments
Open

Universal React starter-kyt - Tools view #579

nicanordlc opened this issue Dec 14, 2018 · 0 comments

Comments

@nicanordlc
Copy link

nicanordlc commented Dec 14, 2018 •
edited
Loading

Hi,

To what it’s worth this is not really crucial since the css file is pretty small but 🤷‍♂️

By looking around I found that in the kyt-universal-starter package that the shared-styles are being imported but not used.

You can see the file right here 👇 https://github.com/NYTimes/kyt/blob/4121828cf1c8061a90f1ed9f69979331bc4a02e1/packages/kyt-starter-universal/starter-src/src/components/Tools/styles.scss#L2-L6

I think that the $padding variable got forgotten.

One of this things can be done.

  • Use the variable $padding on the padding-top property (Values are differents)
  • In the case that the value must be 5px, one can create another value on the shared-styles like small-padding
  • Remove the import and leave the property with its current value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicanordlc