Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Command Argument: direction #15

Open
Vasileios-Mavroeidis opened this issue Feb 5, 2022 · 2 comments
Open

Refine Command Argument: direction #15

Vasileios-Mavroeidis opened this issue Feb 5, 2022 · 2 comments

Comments

@Vasileios-Mavroeidis
Copy link
Member

In section 2.1.3.2 We have defined a new command argument direction of type Direction and we specify that the argument

"Specifies whether to apply rules to incoming or outgoing traffic. If omitted, rules are applied to ingress packets."

I propose removing the second sentence.

What is stated is actuator-specific - the default behavior of the technology. An actuator that gets an OpenC2 command without the argument direction populated will treat the command based on its default behavior (vendor's decision). If the actuator requires specifying the direction, then we should do it. If we don't specify the direction and the actuator does not have a default behavior for such use cases, then the command is invalid.

@Vasileios-Mavroeidis
Copy link
Member Author

Vasileios-Mavroeidis commented Feb 5, 2022

The usage requirements of the argument specify that:

If absent or not explicitly set, then the Command MUST apply to both.

This is in opposition to the description of the argument.

I suggest removing this description/sentence too.

@Vasileios-Mavroeidis
Copy link
Member Author

At the Feb 9th meeting we agreed to refine the language in the spec than eliminating the default behavior of the actuator in the case that the direction argument is not populated. It is a fact that many packet filters dictate default behavior "ingress" when the direction is not specified. An example can be seen here: https://cloud.google.com/vpc/docs/firewalls#direction_of_the_rule

Also, the usage requirements of the argument specify that when absent or not explicitly set, then the Command MUST apply to both. This is wrong and will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant