Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validity of comprehensible Example #600

Open
sthagen opened this issue Aug 6, 2023 · 0 comments
Open

Validity of comprehensible Example #600

sthagen opened this issue Aug 6, 2023 · 0 comments
Assignees
Labels

Comments

@sthagen
Copy link
Contributor

sthagen commented Aug 6, 2023

Following the word to markdown transforms and example extractions we could start validating the extracted examples (most for now only as JSON) four as SARIF JSON.

Unfortunately one of the four SARIF examples from the appendix K does not pass validation against the schema in that branch and revision.

  • This may be an error in the schema (outdated version?) in that branch.
  • It may be an error from the transformation of the example of word into markdown.

In any case this renders the branch state inconsistent between prose (example) and schema.

This ticket shall allow tracking of the analysis and solution of the problem.

Info from the commit fb3a7e17 that documented the detection of the invalid state:

- validated three of the four files against the schema file present in this branch
  and revision. Unfortunately the comprehesnible example fails.
- documentation:
  ❯ schema='../../schema/sarif-schema-2.1.0-errata01-csd01-complete.json'
  ❯ instance='src/json-examples/examples_comprehensive-sarif-file_codeblock-json-1.sarif.json'
  ❯ check-jsonschema --schemafile ${schema} ${instance}
  Schema validation errors were encountered.
    instance...::$.runs[0].invocations[0].toolConfigurationNotifications[0].associatedRule: Additional properties are not allowed ('ruleId' was unexpected)
    instance...::$.runs[0].invocations[0].toolConfigurationNotifications[0].associatedRule: {'ruleId': 'ABC0001'} is not valid under any of the given schemas
    Underlying errors caused this.
    Best Match:
      $.runs[0].invocations[0].toolConfigurationNotifications[0].associatedRule: 'index' is a required property
    instance...::$.runs[0].results[0]: Additional properties are not allowed ('addresses' was unexpected)
@sthagen sthagen self-assigned this Aug 6, 2023
@sthagen sthagen added the bug label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant