Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number Fix Issue (with Fix) #17

Open
rsiddle opened this issue Jun 6, 2014 · 0 comments
Open

Number Fix Issue (with Fix) #17

rsiddle opened this issue Jun 6, 2014 · 0 comments

Comments

@rsiddle
Copy link

rsiddle commented Jun 6, 2014

On this line https://github.com/olkarls/has_permalink/blob/master/lib/has_permalink.rb#L56 the permalink searches for itself so if you update a model, it always appends a number which isn't correct. Instead the 'where' clause should tell it to not count it's own ID

n = self.class.where(["permalink = ? AND id != ?", permalink, id]).count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsiddle