Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: a11y rules "click-events-have-key-events" and "no-static-element-interactions" fail with a warning. #4130

Closed
Tracked by #4139
FatumaA opened this issue Sep 26, 2024 · 3 comments · Fixed by #4169
Assignees
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ released on @beta

Comments

@FatumaA
Copy link
Contributor

FatumaA commented Sep 26, 2024

Describe the bug

jsx-a11y eslint plugin was recently added to the project and these rules -jsx-a11y/click-events-have-key-events and jsx-a11y/no-static-element-interactions - fail with a warning.

This issue offers more context: #2264

Steps to reproduce

The following components and files are causing the rule to fail:

  1. components/atoms/PillSelector/pill-selector.tsx
  2. components/atoms/Radio/radio.tsx
  3. components/atoms/RadioCheck/radio-check.tsx
  4. components/atoms/SVGIcon/svg-icon.tsx
  5. components/atoms/Search/search.tsx
  6. components/atoms/TextInput/text-input.tsx
  7. components/atoms/ToggleOption/toggle-option.tsx
  8. components/molecules/AuthSection/auth-section.tsx
  9. components/molecules/CardRepoList/card-repo-list.tsx
  10. components/molecules/ContributorFilterDropdown/contributor-filter-dropdown.tsx
  11. components/molecules/ContributorHighlight/contributor-highlight-card.tsx
  12. components/molecules/ContributorListTableRow/contributor-list-table-row.tsx
  13. components/molecules/DevCard/dev-card.tsx
  14. components/molecules/HighlightInput/highlight-input-form.tsx
  15. components/molecules/HighlightsFeedCard/highlights-filter-card.tsx
  16. components/molecules/InfoCard/info-card.tsx
  17. components/molecules/RepoRow/repo-row.tsx
  18. components/molecules/ReposoitoryCartItem/repository-cart-item.tsx
  19. components/molecules/SuperlativeSelector/superlative-selector.tsx
  20. components/organisms/DevCardWall/dev-card-wall.tsx
  21. components/organisms/SearchDialog/search-dialog.tsx
  22. pages/u/[username]/card.tsx
@FatumaA FatumaA added 🐛 bug Something isn't working 👀 needs triage labels Sep 26, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@FatumaA
Copy link
Contributor Author

FatumaA commented Sep 26, 2024

.take

@nickytonline nickytonline added hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ a11y Issues related to accessibility labels Oct 1, 2024
Copy link
Contributor

open-sauced bot commented Oct 31, 2024

🎉 This issue has been resolved in version 2.64.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ released on @beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants