Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Improve lighthouse accessibility score. #87

Open
2 tasks done
bdougie opened this issue Dec 14, 2022 · 6 comments · May be fixed by #358
Open
2 tasks done

Bug: Improve lighthouse accessibility score. #87

bdougie opened this issue Dec 14, 2022 · 6 comments · May be fixed by #358
Labels
🐛 bug Something isn't working good first issue Good for newcomers

Comments

@bdougie
Copy link
Member

bdougie commented Dec 14, 2022 •
edited
Loading

Describe the bug

This was reported here.

Looks really cool, but doesn't feel like a website. Any reason why hyperlinks are marked up as

? Also, why do links that lead to a different page trigger a scroll up animation on the same page while page contents changes? It feels disorienting.

Looks like there are few places where we are doing Button or Link is rendering a <div href/>. Opening this issue for tracking reasons.

I have not yet triaged this myself, but we will want to make sure this site passes all accessibility tests now that it is live. This was an oversight on my part.

Steps to reproduce

Run the lighthouse on the site and report issues here. Depending on scope, we can open separate issues for fix in one PR.

Screen Shot 2022-12-14 at 9 34 22 AM

Affected services

opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added good first issue Good for newcomers 🐛 bug Something isn't working labels Dec 14, 2022
@takanome-dev
Copy link

All the buttons except the subscribe newsletter are divs with href.

I ran lighthouse on Firefox and Brave and it got pretty good score imh.
Here are some screenshots:

Brave Desktop

opensauced_lighthouse_1

Brave Modile

opensauced_lighthouse_3

Firefox mobile

opensauced_lighthouse_2

Common for both on mobile

firefox_1
firefox_2
firefox_3
firefox_4
firefox_5
firefox_6

@bdougie
Copy link
Member Author

bdougie commented Jan 3, 2023

I think the focus for this issue should be improving the accessibility score. If updating the links does not improve the score, we should avoid it. I am updating the title to reflect this.

@bdougie bdougie changed the title Bug: <div href> Bug: Improve lighthouse accessibility score. Jan 3, 2023
@CBID2
Copy link

CBID2 commented Aug 11, 2023

@EmmaDawsonDev, I think you can share some great insights on this.

@EmmaDawsonDev
Copy link

Definitely happy to take a look and do an accessibility audit. I'd prioritise fixing the links/buttons over raising the lighthouse score as that's something critical for keyboard users to access the site and not something lighthouse can pick up. But I'm sure there's a lot of small tweaks that can make a big difference

@dev-phantom
Copy link
Contributor

.take

@github-actions
Copy link
Contributor

Thanks for taking this on! If you have not already, join the conversation in our Discord

@dev-phantom dev-phantom mentioned this issue Feb 29, 2024
Closed
16 tasks
@dev-phantom dev-phantom linked a pull request Sep 9, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@bdougie @EmmaDawsonDev @dev-phantom @takanome-dev @CBID2