Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definitions don't seem to get shipped with package. #87

Open
JohannesKlauss opened this issue Aug 4, 2020 · 3 comments
Open

Typescript definitions don't seem to get shipped with package. #87

JohannesKlauss opened this issue Aug 4, 2020 · 3 comments
Labels
in progress Currently being looked into

Comments

@JohannesKlauss
Copy link

Installing this package via yarn add recoilize --dev is missing the typescript definitions.

Bildschirmfoto 2020-08-04 um 10 40 44

I think you are missing the creation of .d.ts files in your tsconfig for the actual npm package.
@JohannesKlauss
Copy link
Author

Also looking into the package/index.ts code I am not quite sure why you are using Typescript in the first place since everything is typed as any.

@jonescamilla jonescamilla added the in progress Currently being looked into label Aug 4, 2020
@jonescamilla
Copy link
Contributor

We intentionally left out the typing in the package due an issue with the compiled version. We are planning to look into it soon. If you can get a TS version compiled and working on your end please feel free in letting us know or submitting a PR. Greatly appreciate it!

@NeoMorfeo
Copy link

@jonescamilla is there any update on this? just wondering if it is posible any update or path to help or test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress Currently being looked into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NeoMorfeo @JohannesKlauss @jonescamilla