Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdatagen: using the wrong package name for a generateFile call #11469

Open
braydonk opened this issue Oct 16, 2024 · 0 comments · May be fixed by #11468
Open

mdatagen: using the wrong package name for a generateFile call #11469

braydonk opened this issue Oct 16, 2024 · 0 comments · May be fixed by #11468
Labels
bug Something isn't working

Comments

@braydonk
Copy link
Contributor

braydonk commented Oct 16, 2024 •
edited
Loading

Describe the bug
In #11232 I missed a spot where "metadata" is still being passed instead of the correct package name. This would cause a faulty generation when using the generated_package_name feature.

opentelemetry-collector/cmd/mdatagen/internal/command.go

Lines 83 to 86 in 388bae7

if err = generateFile(filepath.Join(tmplDir, "status.go.tmpl"),
filepath.Join(codeDir, "generated_status.go"), md, "metadata"); err != nil {
return err
}

Steps to reproduce
Off of 388bae7 (this is not in a released version of mdatagen), generate a package with a custom name. generated_status.go will have the wrong package name (metadata instead of the intended generated_package_name).

Additional context
As previously mentioned, this bug is not present in a released version of mdatagen yet.
@braydonk braydonk added the bug Something isn't working label Oct 16, 2024
@braydonk braydonk linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mdatagen: get package name from metadata braydonk/opentelemetry-collector
1 participant
@braydonk