Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename deprecated metrics #11203

Open
codeboten opened this issue Sep 17, 2024 · 2 comments · May be fixed by #11280 or #11585
Open

rename deprecated metrics #11203

codeboten opened this issue Sep 17, 2024 · 2 comments · May be fixed by #11280 or #11585
Assignees
@JamieDanielson
Labels
processor/memory_limiter

Comments

@codeboten
Copy link
Contributor

The following metrics are being deprecated as they were only used in the memory limiter processor:
- otelcol_processor_accepted_log_records
- otelcol_processor_accepted_metric_points
- otelcol_processor_accepted_spans
- otelcol_processor_dropped_log_records
- otelcol_processor_dropped_metric_points
- otelcol_processor_dropped_spans
- otelcol_processor_refused_log_records
- otelcol_processor_refused_metric_points
- otelcol_processor_refused_spans

This issue is to make a decision as to what to do with these metrics. They could be renamed to otelcol_processor_memory_limiter_* to identify that these metrics are specific to this one processor.
@JamieDanielson
Copy link
Member

@codeboten can you assign to me? I'll pick this up

@codeboten
Copy link
Contributor Author

Thanks @JamieDanielson! Done

@JamieDanielson JamieDanielson linked a pull request Sep 25, 2024 that will close this issue
Draft
@codeboten codeboten changed the title decision around deprecated metrics rename deprecated metrics Oct 2, 2024
@JamieDanielson JamieDanielson linked a pull request Oct 31, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieDanielson JamieDanielson

Labels
processor/memory_limiter
Projects
None yet
Milestone
No milestone
2 participants
@codeboten @JamieDanielson