Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang 18 inline failure #223

Open
gnurizen opened this issue Nov 4, 2024 · 1 comment
Open

Clang 18 inline failure #223

gnurizen opened this issue Nov 4, 2024 · 1 comment

Comments

@gnurizen
Copy link
Contributor

gnurizen commented Nov 4, 2024

Clang 18 fails to produce a working unwinder because the event_send_trigger function isn't inlined and the 5.4 kernels complain about bpf calls and bpf-tail calls both being present not being allowed. I guess "static inline" isn't strong enough and we need to break out the always_inline attribute?

Proposal:

  1. Use static inline attribute((always_inline))
  2. Create an OPTI_INLINE macro that expands to this use that everywhere
@rockdaboot
Copy link
Contributor

rockdaboot commented Nov 5, 2024

Can you give more details about your clang version and architecture?
Because this issue is not reproducible here :)

$ clang-18 --version
Debian clang version 18.1.8 (12)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

$ uname -a
Linux P15v 6.11.4-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.11.4-1 (2024-10-20) x86_64 GNU/Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants