-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit prometheus exemplar label characters to conform to prometheus limits #6770
Comments
hi @jack-berg , However, when i tried writing the test case by creating a sample Metric data with exemplar, I noticed that I could not find any tests validating whether exemplar objects's labels are being validated anywhere during otel 2 prometheus conversion. |
To use exemplars we need to use OpenMetrics exposition format writer. ref: https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#exemplars-experimental |
Yup. @fstab is this actually an issue with prometheus/client_java? Should the |
Originally posted by @myeongseok-rpls in open-telemetry/opentelemetry-java-instrumentation#12411
As discussed in the issue, prometheus has a limit on the allowed characters in exemplars. The java prometheus exporter should not produce exemplars which violate this limit. Currently, the limit appears to be hard coded to 128 characters.
The text was updated successfully, but these errors were encountered: