Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version of the proto that introduced a field in the comments #535

Open
tigrannajaryan opened this issue Mar 21, 2024 · 0 comments
Open

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Mar 21, 2024

The spec uses labels like since 1.23.0 to indicate which version added the particular capability.

I wonder if we want to use a similar labeling in the form of comments when new capabilities are added to OTLP proto. This would make it easier for OTLP implementors to understand what new capabilities they need to implement. Implementations can also publish the version number they conform to and that in turn will allow users of OTLP implementations to understand which capabilities of OTLP the implementation supports.

An example of a field that would be labeled is Metric metadata introduced here.

Important: this has nothing to do with having a runtime version number in the proto or elsewhere on the wire (which was a feature that we discussed in the past and decided not to add).

@dashpole @jsuereth and @open-telemetry/specs-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant