Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ability to inject attributes into sqlalchemy spans to control sampling #2788

Open
jochs opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2733
Open

Feature: ability to inject attributes into sqlalchemy spans to control sampling #2788

jochs opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2733

Comments

@jochs
Copy link

jochs commented Aug 8, 2024

What problem do you want to solve?

I use a custom sampler that allows overriding of sampling decisions based on attributes, but I can't use that sampler in the sqlalchemy instrumentor because there is no way to pass attributes.

Describe the solution you'd like

Add an optional 0-argument callable as a kwarg to the instrumentor which lets you inject attributes at sample start time. #2733

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant