You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I changed generate_workflows_lib here and tests were green, unfortunately it broke core because the new behaviour does not fit what core is doing. If we change .github/workflows/generate_workflows_lib we should probably run a new job that is checking out core and testing that the generation is not different than what was before. We can use the skip-generate-workflows to ignore any error if really we want a behavior change
Additional context
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered:
Alternatively, maybe we can have another copy of generate_workflows.py on core to generate the core specific workflows so we reduce the dependency on contrib (although we would still need it for the contrib.yml workflow but at least it reduces the conflicts).
Describe your environment
OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)
What happened?
I changed generate_workflows_lib here and tests were green, unfortunately it broke core because the new behaviour does not fit what core is doing. If we change .github/workflows/generate_workflows_lib we should probably run a new job that is checking out core and testing that the generation is not different than what was before. We can use the skip-generate-workflows to ignore any error if really we want a behavior change
Additional context
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: